[
https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203810#comment-16203810
]
ASF GitHub Bot commented on FLINK-7456:
---------------------------------------
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@pnowojski , this PR is ready for review.
It covers almost all the logics of credit-based on sender side.
In addition, I replace the current `PartitionRequestClientHandler` with
`CreditBasedClientHandler` and remove previous temporary codes for making this
feature work on both sides.
It leaves a small work to do in this PR related with
`SpilledSubpartitionView#nextBufferIsEvent` because the existing process in
spilled sub-partition can not get next buffer directly. But the current default
value for `nextBufferIsEvent`` will not affect the core process, only results
in wasting a unnecessary credit, then I will try to solve it in a lightweight
way later.
> Implement Netty sender incoming pipeline for credit-based
> ---------------------------------------------------------
>
> Key: FLINK-7456
> URL: https://issues.apache.org/jira/browse/FLINK-7456
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control.
> On sender side, each subpartition view maintains an atomic integer
> {{currentCredit}} from receiver. Once receiving the messages of
> {{PartitionRequest}} and {{AddCredit}}, the {{currentCredit}} is added by
> deltas.
> Each view also maintains an atomic boolean field to mark it as registered
> available for transfer to make sure it is enqueued in handler only once. If
> the {{currentCredit}} increases from zero and there are available buffers in
> the subpartition, the corresponding view will be enqueued for transferring
> data.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
