Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4837#discussion_r144850901
  
    --- Diff: flink-libraries/flink-table/pom.xml ---
    @@ -213,36 +209,49 @@ under the License.
                                                                <filter>
                                                                        
<artifact>*:*</artifact>
                                                                        
<excludes>
    +                                                                           
<!-- excluded all these files for a clean flink-table jar -->
                                                                                
<exclude>org-apache-calcite-jdbc.properties</exclude>
    +                                                                           
<exclude>common.proto</exclude>
    +                                                                           
<exclude>requests.proto</exclude>
    +                                                                           
<exclude>responses.proto</exclude>
                                                                                
<exclude>mozilla/**</exclude>
                                                                                
<exclude>codegen/**</exclude>
                                                                                
<exclude>google/**</exclude>
                                                                                
<exclude>META-INF/*.SF</exclude>
                                                                                
<exclude>META-INF/*.DSA</exclude>
                                                                                
<exclude>META-INF/*.RSA</exclude>
    +                                                                           
<exclude>META-INF/services/**</exclude>
    +                                                                           
<exclude>properties.dtd</exclude>
    +                                                                           
<exclude>PropertyList-1.0.dtd</exclude>
    +                                                                           
<exclude>digesterRules.xml</exclude>
    +                                                                           
<!-- not excluded for now -->
    --- End diff --
    
    why not?


---

Reply via email to