[ 
https://issues.apache.org/jira/browse/FLINK-7861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207525#comment-16207525
 ] 

ASF GitHub Bot commented on FLINK-7861:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4845

    [FLINK-7861] [flip6] Suppress ActorKilledException logging

    ## What is the purpose of the change
    
    Introduce a StoppingSupervisorWithoutLoggingStrategy which only logs the
    ActorKilledException on debug level and all other exceptions on error level.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink 
suppressActorKilledExceptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4845
    
----
commit 2b6aaec0889b0cce8d224712e6ea9bc0f2f4e79a
Author: Till <[email protected]>
Date:   2017-10-17T11:39:07Z

    [FLINK-7861] [flip6] Suppress ActorKilledException logging
    
    Introduce a StoppingSupervisorWithoutLoggingStrategy which only logs the
    ActorKilledException on debug level and all other exceptions on error level.

----


> Suppress ActorKilledExceptions
> ------------------------------
>
>                 Key: FLINK-7861
>                 URL: https://issues.apache.org/jira/browse/FLINK-7861
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> When stopping a {{RpcEndpoint}}, the {{AkkaRpcService}} sends a {{Kill}} 
> message which causes an {{ActorKilledException}} to be thrown. This exception 
> is logged by the {{StoppingSupervisorStrategy}}. This is not necessary 
> because we voluntarily stopped the {{RpcEndpoint}}. In order to clean up 
> logs, I think we should not log this kind of exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to