Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4842#discussion_r145299001
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala
 ---
    @@ -82,6 +82,45 @@ class CorrelateITCase extends 
StreamingMultipleProgramsTestBase {
         assertEquals(expected.sorted, StreamITCase.testResults.sorted)
       }
     
    +  /**
    +    * Due to CALCITE-2004, common join predicates are temporarily 
forbidden.
    +    */
    +  @Test (expected = classOf[ValidationException])
    +  def testLeftOuterJoinWithPredicates(): Unit = {
    --- End diff --
    
    This is the same with the batch fashion.
    > This test should have been used as a normal test case for this join, 
i.e., we don't expect it to raise an exception. I'd suggest to keep it for 
later use, otherwise we may not be aware the test is incomplete in the future.


---

Reply via email to