[ 
https://issues.apache.org/jira/browse/FLINK-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210815#comment-16210815
 ] 

ASF GitHub Bot commented on FLINK-7759:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4829#discussion_r145653182
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/stringexpr/StringExpressionTest.scala
 ---
    @@ -0,0 +1,51 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.api.batch.table.stringexpr
    +
    +import org.apache.flink.table.expressions.{ExpressionParser, Literal, 
UnresolvedFieldReference}
    +import org.junit.{Assert, Test}
    +
    +class StringExpressionTest {
    --- End diff --
    
    I've converted the test into an expression test (extending 
`ExpressionTestBase`) and moved it to `org.apache.flink.table.expressions`.


> Fix Bug that fieldName with Boolean prefix can't be parsed by 
> ExpressionParser.
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-7759
>                 URL: https://issues.apache.org/jira/browse/FLINK-7759
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> just call {{ExpressionParser.parseExpression}} with a prefix equals "true" or 
> "false"
> {{ExpressionParser.parseExpression("true_target")}} or 
> {{ExpressionParser.parseExpression("falsex")}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to