[ 
https://issues.apache.org/jira/browse/FLINK-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210920#comment-16210920
 ] 

ASF GitHub Bot commented on FLINK-7872:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4859

    [FLINK-7872] Allow to pass in additional HTTP headers

    ## What is the purpose of the change
    
    HandlerUtils#sendResponse now accepts a map of additional http response 
headers
    and their values. This allows to set additional headers such as the
    ACCESS_CONTROL_ALLOW_ORIGIN header and its value.
    
    ## Verifying this change
    
    Manually tested.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink additionalHttpHeaders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4859
    
----
commit a61e6982c9bd88c72e28169664bdb87576e62a57
Author: Till <[email protected]>
Date:   2017-10-19T09:06:41Z

    [FLINK-7872] Allow to pass in additional HTTP headers
    
    HandlerUtils#sendResponse now accepts a map of additional http response 
headers
    and their values. This allows to set additional headers such as the
    ACCESS_CONTROL_ALLOW_ORIGIN header and its value.

----


> Set ACCESS_CONTROL_ALLOW_ORIGIN header in HandlerUtils#sendResponse
> -------------------------------------------------------------------
>
>                 Key: FLINK-7872
>                 URL: https://issues.apache.org/jira/browse/FLINK-7872
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> The {{HandlerUtils#sendResponse}} should have an option to pass in additional 
> headers such as the {{ACCESS_CONTROL_ALLOW_ORIGIN}} header.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to