Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r144244479
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -304,12 +304,21 @@ public void testProducerFailedException() throws
Exception {
/**
* Tests {@link RemoteInputChannel#recycle(MemorySegment)}, verifying
the exclusive segment is
- * recycled to available buffers directly and it triggers notify of
announced credit.
+ * recycled to available buffers directly and it triggers notification
of unannounced credit.
*/
@Test
public void testRecycleExclusiveBufferBeforeReleased() throws Exception
{
+ // Config
+ final Tuple2<Integer, Integer> backoff = new Tuple2<>(0, 0);
+
+ // Setup
+ final PartitionRequestClient connClient =
mock(PartitionRequestClient.class);
final SingleInputGate inputGate = mock(SingleInputGate.class);
- final RemoteInputChannel inputChannel =
spy(createRemoteInputChannel(inputGate));
+
+ RemoteInputChannel inputChannel =
spy(createRemoteInputChannel(inputGate, connClient, backoff));
--- End diff --
why did you have to explicitly create `PartitionRequestClient` and
`backoff`?
---
