[
https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212136#comment-16212136
]
ASF GitHub Bot commented on FLINK-5372:
---------------------------------------
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4855
Thanks for the review! Will merge this.
> Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()
> --------------------------------------------------------------
>
> Key: FLINK-5372
> URL: https://issues.apache.org/jira/browse/FLINK-5372
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Reporter: Aljoscha Krettek
> Assignee: Stefan Richter
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.4.0
>
>
> The test is currently {{@Ignored}}. We have to change
> {{AsyncCheckpointOperator}} to make sure that we can run fully
> asynchronously. Then, the test will still fail because the canceling
> behaviour was changed in the meantime.
> {code}
> public static class AsyncCheckpointOperator
> extends AbstractStreamOperator<String>
> implements OneInputStreamOperator<String, String> {
> @Override
> public void open() throws Exception {
> super.open();
> // also get the state in open, this way we are sure that it was
> created before
> // we trigger the test checkpoint
> ValueState<String> state = getPartitionedState(
> VoidNamespace.INSTANCE,
> VoidNamespaceSerializer.INSTANCE,
> new ValueStateDescriptor<>("count",
> StringSerializer.INSTANCE, "hello"));
> }
> @Override
> public void processElement(StreamRecord<String> element) throws Exception
> {
> // we also don't care
> ValueState<String> state = getPartitionedState(
> VoidNamespace.INSTANCE,
> VoidNamespaceSerializer.INSTANCE,
> new ValueStateDescriptor<>("count",
> StringSerializer.INSTANCE, "hello"));
> state.update(element.getValue());
> }
> @Override
> public void snapshotState(StateSnapshotContext context) throws Exception {
> // do nothing so that we don't block
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
