Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4798#discussion_r146161007
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -313,10 +317,16 @@ public void dispose() {
                IOUtils.closeQuietly(dbOptions);
                IOUtils.closeQuietly(columnOptions);
     
    +           cleanInstanceBasePath();
    --- End diff --
    
    This again would not need the existence check that runs inside the method, 
because at this point the directory should always exist.


---

Reply via email to