[ 
https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591488#comment-14591488
 ] 

ASF GitHub Bot commented on FLINK-2124:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/848#discussion_r32709133
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java
 ---
    @@ -17,37 +17,71 @@
     
     package org.apache.flink.streaming.api.functions.source;
     
    -import java.util.Arrays;
    -import java.util.Collection;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.InputViewDataInputStreamWrapper;
    +import org.apache.flink.core.memory.OutputViewDataOutputStreamWrapper;
    +
    +import java.io.*;
    --- End diff --
    
    The checkstyle plugin complains about the `.*` import here. You have to 
import the different streams explicitly.


> FromElementsFunction is not really Serializable
> -----------------------------------------------
>
>                 Key: FLINK-2124
>                 URL: https://issues.apache.org/jira/browse/FLINK-2124
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> The function stores an Iterable of T. T is not necessarily Serializable and 
> and Iterable is also not necessarily Serializable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to