[ 
https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217024#comment-16217024
 ] 

ASF GitHub Bot commented on FLINK-4877:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4877
  
    Thanks for opening this pull request.
    
    I think it is correct that `SourceFunction` is not required to implement 
`Serializable`. But I think it does not cause any problems, as far as I know, 
it has no implication at all on the runtime or behavior.
    
    It does serve as a "reminder" that sources need to be serializable, so it 
could actually be helpful to keep it.
    
    Given that it makes no difference, should we keep it?


> Refactorings around FLINK-3674 (User Function Timers)
> -----------------------------------------------------
>
>                 Key: FLINK-4877
>                 URL: https://issues.apache.org/jira/browse/FLINK-4877
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>             Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to