Github user uce commented on the pull request:
https://github.com/apache/flink/pull/850#issuecomment-113119208
So, we have been handling `null` values inconsistently from what I can see.
`LongValue` checks for `null` whereas the changed classes in this PR did not.
The equals contract is to return `false` for `obj.equals(null)` but I think
there are [fair arguments for throwing
NPE](http://stackoverflow.com/questions/2887761/is-it-a-bad-idea-if-equalsnull-throws-nullpointerexception-instead)
as well.
I think it's good to have it consistent in all `Value` classes. I'm in
favor of your change, but it is essentially API breaking. There could be
someone out there relying on the NPE. ;-)
Need more opinions on this, @tillrohrmann, @fhueske.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
