[
https://issues.apache.org/jira/browse/FLINK-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218303#comment-16218303
]
ASF GitHub Bot commented on FLINK-7666:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4900#discussion_r146802292
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
---
@@ -199,12 +214,20 @@ int getNumTasksScheduled() {
*/
private static final class TriggerTask implements Runnable {
+ private final SystemProcessingTimeService timerService;
private final Object lock;
private final ProcessingTimeCallback target;
private final long timestamp;
private final AsyncExceptionHandler exceptionHandler;
- TriggerTask(AsyncExceptionHandler exceptionHandler, final
Object lock, ProcessingTimeCallback target, long timestamp) {
+ private TriggerTask(
--- End diff --
We should only hand in the `status` field here, not the complete timer
service because that potentially exposes to many things.
> ContinuousFileReaderOperator swallows chained watermarks
> --------------------------------------------------------
>
> Key: FLINK-7666
> URL: https://issues.apache.org/jira/browse/FLINK-7666
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 1.3.2
> Reporter: Ufuk Celebi
> Assignee: Kostas Kloudas
> Priority: Blocker
> Fix For: 1.4.0
>
>
> I use event time and read from a (finite) file. I assign watermarks right
> after the {{ContinuousFileReaderOperator}} with parallelism 1.
> {code}
> env
> .readFile(new TextInputFormat(...), ...)
> .setParallelism(1)
> .assignTimestampsAndWatermarks(...)
> .setParallelism(1)
> .map()...
> {code}
> The watermarks I assign never progress through the pipeline.
> I can work around this by inserting a {{shuffle()}} after the file reader or
> starting a new chain at the assigner:
> {code}
> env
> .readFile(new TextInputFormat(...), ...)
> .setParallelism(1)
> .shuffle()
> .assignTimestampsAndWatermarks(...)
> .setParallelism(1)
> .map()...
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
