Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-113213190
This looks very nice! Someone deserves a virtual :ice_cream: !
There are some tests missing:
- test `fromCSV` with a Mapper
- you just test `types`, `ignoreFirstLines` and `ignoreComments`; let's at
least add tests for the `lineDelimiter*` and the `fieldDelimiter*` methods. I'm
sure they work, but tests are written to guarantee that the functionality will
also be there (at the same quality) in the future (i.e. some exotic code
addition will not break it) :)
I saw an outdated Vasia comment on an unused import; always hit mvn verify
before pushing - it would have caught that :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
