[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592072#comment-14592072
]
ASF GitHub Bot commented on FLINK-1520:
---------------------------------------
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-113213190
This looks very nice! Someone deserves a virtual :ice_cream: !
There are some tests missing:
- test `fromCSV` with a Mapper
- you just test `types`, `ignoreFirstLines` and `ignoreComments`; let's at
least add tests for the `lineDelimiter*` and the `fieldDelimiter*` methods. I'm
sure they work, but tests are written to guarantee that the functionality will
also be there (at the same quality) in the future (i.e. some exotic code
addition will not break it) :)
I saw an outdated Vasia comment on an unused import; always hit mvn verify
before pushing - it would have caught that :D
> Read edges and vertices from CSV files
> --------------------------------------
>
> Key: FLINK-1520
> URL: https://issues.apache.org/jira/browse/FLINK-1520
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Shivani Ghatge
> Priority: Minor
> Labels: easyfix, newbie
>
> Add methods to create Vertex and Edge Datasets directly from CSV file inputs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
