[
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219568#comment-16219568
]
ASF GitHub Bot commented on FLINK-5823:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4907#discussion_r146992430
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackendFactory.java
---
@@ -18,45 +18,41 @@
package org.apache.flink.runtime.state.filesystem;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.configuration.CheckpointingOptions;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.IllegalConfigurationException;
import org.apache.flink.core.fs.Path;
import org.apache.flink.runtime.state.StateBackendFactory;
-import java.io.IOException;
+import java.net.URI;
/**
- * A factory that creates an {@link
org.apache.flink.runtime.state.filesystem.FsStateBackend}
- * from a configuration.
+ * A factory that creates an {@link FsStateBackend} from a configuration.
*/
+@PublicEvolving
public class FsStateBackendFactory implements
StateBackendFactory<FsStateBackend> {
-
- /** The key under which the config stores the directory where
checkpoints should be stored */
- public static final String CHECKPOINT_DIRECTORY_URI_CONF_KEY =
"state.backend.fs.checkpointdir";
-
- /** The key under which the config stores the threshold for state to be
store in memory,
- * rather than in files */
- public static final String MEMORY_THRESHOLD_CONF_KEY =
"state.backend.fs.memory-threshold";
-
@Override
public FsStateBackend createFromConfig(Configuration config) throws
IllegalConfigurationException {
--- End diff --
Wouldn't it make sense to do all of this in `configure()`? The factories
are essentially useless now and would only instantiate the backend and then
call `configure()` with the config.
> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
> Key: FLINK-5823
> URL: https://issues.apache.org/jira/browse/FLINK-5823
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Blocker
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
