[
https://issues.apache.org/jira/browse/FLINK-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220199#comment-16220199
]
ASF GitHub Bot commented on FLINK-7840:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4827#discussion_r147087742
--- Diff: flink-runtime/pom.xml ---
@@ -427,17 +427,42 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+ <!-- we need this to
avoid having to specify all of akka's dependencies -->
+
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
--- End diff --
This adds `akka-remote`'s dependencies as direct dependencies to
`flink-runtime` (like for example `reactive-streams`).
Without promoting transitive dependencies, we would need to add all
transitive dependencies of `akka-remote` to the shaded jar, because
`akka-remote` is removed as a dependency which also removes its transitive
dependencies.
We could do that, but since we cannot relocate many of them (Scala) I
though to keep the set of dependencies that are "present but undeclared" small
and treat akka-remote's dependencies like regular dependencies.
> Shade Akka's Netty Dependency
> -----------------------------
>
> Key: FLINK-7840
> URL: https://issues.apache.org/jira/browse/FLINK-7840
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.4.0
>
>
> In order to avoid clashes between different Netty versions we should shade
> Akka's Netty away.
> These dependency version clashed manifest themselves in very subtle ways,
> like occasional deadlocks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
