Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4873#discussion_r147120015
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -849,17 +848,7 @@ object AggregateUtil {
outputType
)
- val constantFlags: Option[Array[(Int, Boolean)]] =
- if (inGroupingSet) {
-
- val groupingSetsMapping = getGroupingSetsIndicatorMapping(inputType,
outputType)
--- End diff --
`getGroupingSetsIndicatorMapping()` method can be removed as well
everything related to the `constantFlags` parameter in
`AggregationCodeGenerator`, `GeneratedAggregations`,
`DawtaSetFinalAggFunction`, etc.
---
