[ https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224816#comment-16224816 ]
ASF GitHub Bot commented on FLINK-7784: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4910#discussion_r147687514 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -362,4 +483,39 @@ public void setContext(Optional<CONTEXT> context) { this.context = context; } } + + /** + * Adds metadata (currently only the start time of the transaction) to the transaction object. + */ + @VisibleForTesting + static class TransactionHolder<TXN> { --- End diff -- I will leave it as is. It's an internal class and it is clear what it does. > Don't fail TwoPhaseCommitSinkFunction when failing to commit > ------------------------------------------------------------ > > Key: FLINK-7784 > URL: https://issues.apache.org/jira/browse/FLINK-7784 > Project: Flink > Issue Type: Bug > Components: DataStream API > Affects Versions: 1.4.0 > Reporter: Aljoscha Krettek > Assignee: Gary Yao > Priority: Blocker > Fix For: 1.4.0 > > > Currently, {{TwoPhaseCommitSinkFunction}} will fail if committing fails > (either when doing it via the completed checkpoint notification or when > trying to commit after restoring after failure). This means that the job will > go into an infinite recovery loop because we will always keep failing. > In some cases it might be better to ignore those failures and keep on > processing and this should be the default. We can provide an option that > allows failing the sink on failing commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)