Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4919#discussion_r147672995
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -958,29 +960,34 @@ public int compare(PartitionInfo o1, PartitionInfo
o2) {
/**
* State for handling transactions.
*/
- public static class KafkaTransactionState {
+ static class KafkaTransactionState {
private final transient FlinkKafkaProducer<byte[], byte[]>
producer;
@Nullable
- public final String transactionalId;
+ final String transactionalId;
- public final long producerId;
+ final long producerId;
- public final short epoch;
+ final short epoch;
- public KafkaTransactionState(String transactionalId,
FlinkKafkaProducer<byte[], byte[]> producer) {
--- End diff --
The `public` is not needed as the whole class is not public.
---
