GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4922
[hotfix][metrics] Cleanup ScopeFormats
## What is the purpose of the change
This PR cleans up a few things related to `ScopeFormats`.
## Brief change log
* remove unused constructor
* remove redundant `MetricRegistryConfiguration#createScopeConfig`
* remove unnecessary default constructor (passing an empty configuration
instead is easier to maintain)
* limit visibility of constructor
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink metrics_hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4922
----
commit 3211152f9b0d357c40fef6f924ca9170ba34d3a5
Author: zentol <ches...@apache.org>
Date: 2017-10-30T14:07:52Z
[hotfix][metrics] Remove MetricRegistryConfiguration#createScopeConfig
This method duplicates ScopeFormats#fromConfig
commit 5fcd4d64fba1aaa1e093dc70bcf19087604debc4
Author: zentol <ches...@apache.org>
Date: 2017-10-30T14:09:42Z
[hotfix][metrics] Remove unused ScopeFormats constructor
commit 5be7e4e648d2426cd59ebeb0872d03d1202642e8
Author: zentol <ches...@apache.org>
Date: 2017-10-30T14:11:39Z
[hotfix][metrics] Remove unnecessary ScopeFormats constructor
commit bbd3b8f5c955a46cfa72d13136110f3ec959f459
Author: zentol <ches...@apache.org>
Date: 2017-10-30T14:12:00Z
[hotfix][metrics] Limit visibility of ScopeFormats constructor
----
---
