[
https://issues.apache.org/jira/browse/FLINK-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233988#comment-16233988
]
ASF GitHub Bot commented on FLINK-7944:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4920
My first thought is that moving libraries around is maybe not the best
approach.
Also, this seems like it implements a mix between explicitly configuring
the Hadoop Classpath and implicitly picking up env variables.
I would suggest to actually take a step back, make a proper design doc how
we want this to work. If we add configuration scripts, why not make it an "all
explicit, no magic" approach?
Minor comments:
- `bin/hadoop-classpath` seems like the wrong destination. Such files
should be in `conf`.
> Allow configuring Hadoop Classpath
> ----------------------------------
>
> Key: FLINK-7944
> URL: https://issues.apache.org/jira/browse/FLINK-7944
> Project: Flink
> Issue Type: Improvement
> Components: Startup Shell Scripts
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Fix For: 1.4.0
>
>
> Currently, we have some paths hardcoded in {{config.sh}} in addition to some
> magic that tries to derive a classpath from the {{hadoop}}/{{hbase}}
> commands. We should make the classpath configurable using a separate script
> and put the classpath in a {{classpath}} file that will be picked up by the
> scripts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
