GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4932
[FLINK-7958][metrics] Allow reporters to define default delimiter
## What is the purpose of the change
This PR allows reporters to define their default delimiter. Previously we
always defaulted to `.`.
Reporters may now implement the `DelimiterProvider` interface with which
they may define a delimiter. This delimiter is used if no delimiter was
explicitly configured for the reporter.
## Brief change log
* Add DelimiterProvider interface
* modify Prometheus&JmxReporter to define the default delimiter
* modify delimiter setup in the MetricRegistry
* add a test to the MetricRegistryTest to verify functionality
## Verifying this change
This change added tests and can be verified as follows:
Run MetricRegistryTest#testDelimiterOverride.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4932.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4932
----
commit 5286a1d89b71aa00252e2217f20e08352e120257
Author: zentol <[email protected]>
Date: 2017-11-01T13:08:02Z
[FLINK-7958][metrics] Allow reporters to define default delimiter
----
---
