[
https://issues.apache.org/jira/browse/FLINK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234491#comment-16234491
]
ASF GitHub Bot commented on FLINK-7958:
---------------------------------------
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4932
I would suggest another solution - rather than adding another interface
'DelimiterProvider', add `getDelimiter()` which returns '.' as an interface
default method to `MetricReporter`. Any reporter impl classes that don't
override it will use the default delimiter.
BTW, is it better to have `String getDelimiter()` rather than `char
getDelimiter()`? Because 1) Flink has to convert char to string anyway 2) the
former one provides more flexibility in defining delimiters, e.g. as multi
chars
> Allow reporters to override the default delimiter
> -------------------------------------------------
>
> Key: FLINK-7958
> URL: https://issues.apache.org/jira/browse/FLINK-7958
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.5.0
>
>
> By default Flink uses a period to separate scope components. This is however
> not the default for all reporters, which results in either users having to
> override the delimiter manually or reporters working around this issue.
> It would be cleaner if the would let reporters define their own default
> delimiter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
