Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/747#issuecomment-113898364
Thanks for the design outline guys, it looks great. Two minor comments in
terms of implementation:
* Let us make some more emphasis on the architecture of discarding or
compaction old checkpoint data. This seems a minor issue, but we have seen
during the recent release testing that it has implications. [1] In the current
version the `JobManager` discards old state, so it needs access to it. If I
understand it correctly that behavior is intact after this PR.
* API: `KeyedDataStream` should be feasible if we really make it a more
general version of data stream. The interplay with windowed and connected
streams is interesting. The reason why e.g. a windowed and grouping fits nicely
is that the windowed groups contain only elements from one group. You propose
the same design for keyed streams as well?
[1] https://issues.apache.org/jira/browse/FLINK-2221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
