Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r148604013
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -304,22 +304,21 @@ public WebRuntimeMonitor(
get(router, new JobAccumulatorsHandler(executionGraphCache,
scheduledExecutor));
get(router, new TaskManagersHandler(scheduledExecutor,
DEFAULT_REQUEST_TIMEOUT, metricFetcher));
- get(router,
- new TaskManagerLogHandler(
- retriever,
- scheduledExecutor,
- localRestAddress,
- timeout,
- TaskManagerLogHandler.FileMode.LOG,
- config));
- get(router,
- new TaskManagerLogHandler(
- retriever,
- scheduledExecutor,
- localRestAddress,
- timeout,
- TaskManagerLogHandler.FileMode.STDOUT,
- config));
+ get(router, new TaskManagerLogHandler(
+ retriever,
+ scheduledExecutor,
+ localRestAddress,
+ timeout,
+
TaskManagerLogHandler.FileMode.LOG,
+ config));
+ get(router, new TaskManagerLogHandler(
+ retriever,
+ scheduledExecutor,
+ localRestAddress,
+ timeout,
+
TaskManagerLogHandler.FileMode.STDOUT,
+ config));
+ get(router, new TaskManagerMetricsHandler(scheduledExecutor,
metricFetcher));
--- End diff --
why are you adding things to the old `WebRuntimeMonitor`?
---
