[
https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236252#comment-16236252
]
ASF GitHub Bot commented on FLINK-7694:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r148606599
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobMetricsHandlerTest.java
---
@@ -65,15 +65,28 @@ public void getMapFor() throws Exception {
assertEquals("2", metrics.get("abc.metric3"));
assertEquals("3", metrics.get("abc.metric4"));
+ assertEquals(
+ "[" +
+ "{\"id\":\"abc.metric4\"}," +
+ "{\"id\":\"abc.metric3\"}" +
+ "]",
+ handler.getAvailableMetricsList(pathParams));
+ assertEquals("", handler.getMetricsValues(pathParams, ""));
+ assertEquals(
+ "[" +
+
"{\"id\":\"abc.metric3\",\"value\":\"2\"}," +
+
"{\"id\":\"abc.metric4\",\"value\":\"3\"}" +
+ "]",
+ handler.getMetricsValues(pathParams,
"abc.metric3,abc.metric4"));
}
@Test
public void getMapForNull() {
MetricFetcher fetcher = new MetricFetcher(
- mock(GatewayRetriever.class),
- mock(MetricQueryServiceRetriever.class),
- Executors.directExecutor(),
- TestingUtils.TIMEOUT());
+
mock(GatewayRetriever.class),
+
mock(MetricQueryServiceRetriever.class),
+
Executors.directExecutor(),
+
TestingUtils.TIMEOUT());
--- End diff --
Please revert
> Port JobMetricsHandler to new REST handler
> ------------------------------------------
>
> Key: FLINK-7694
> URL: https://issues.apache.org/jira/browse/FLINK-7694
> Project: Flink
> Issue Type: Sub-task
> Components: REST, Webfrontend
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
