GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/4940
[FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator. ## What is the purpose of the change Split current `CodeGenerator` into two dedicated classes, `CodeGeneratorContext` and `ExprCodeGenerator`. The `CodeGeneratorContext` is responsible for maintaining various reusable statements that could be insert into the final generated class, while the `ExprCodeGenerator` is responsible for generating codes for `RexNode` and generating result convertion codes. ## Brief change log - *Remove `CodeGenerator` and introduce `ExprCodeGenerator` and `CodeGeneratorContext`* - *Make some code generator static* ## Verifying this change *(Please pick either of the following options)* This change is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no ) ## Documentation - Does this pull request introduce a new feature? (no) You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-7959 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4940.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4940 ---- commit 77b2d0ac00671347b0952719d70e2eb8230cd8d4 Author: Kurt Young <ykt...@gmail.com> Date: 2017-11-03T07:37:22Z [FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator. ---- ---