[
https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237221#comment-16237221
]
ASF GitHub Bot commented on FLINK-7959:
---------------------------------------
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/4940
[FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and
ExprCodeGenerator.
## What is the purpose of the change
Split current `CodeGenerator` into two dedicated classes,
`CodeGeneratorContext` and `ExprCodeGenerator`. The `CodeGeneratorContext` is
responsible for maintaining various reusable statements that could be insert
into the final generated class, while the `ExprCodeGenerator` is responsible
for generating codes for `RexNode` and generating result convertion codes.
## Brief change log
- *Remove `CodeGenerator` and introduce `ExprCodeGenerator` and
`CodeGeneratorContext`*
- *Make some code generator static*
## Verifying this change
*(Please pick either of the following options)*
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink flink-7959
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4940
----
commit 77b2d0ac00671347b0952719d70e2eb8230cd8d4
Author: Kurt Young <[email protected]>
Date: 2017-11-03T07:37:22Z
[FLINK-7959] [table] Split CodeGenerator into CodeGeneratorContext and
ExprCodeGenerator.
----
> Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator
> -------------------------------------------------------------------
>
> Key: FLINK-7959
> URL: https://issues.apache.org/jira/browse/FLINK-7959
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Kurt Young
> Priority: Major
>
> Right now {{CodeGenerator}} actually acts two roles, one is responsible for
> generating codes from RexNode, and the other one is keeping lots of reusable
> statements. It makes more sense to split these logic into two dedicated
> classes.
> The new {{CodeGeneratorContext}} will keep all the reusable statements, while
> the new {{ExprCodeGenerator}} will only do generating codes from RexNode.
> And for classes like {{AggregationCodeGenerator}} or
> {{FunctionCodeGenerator}}, I think the should not be the subclasses of the
> {{CodeGenerator}}, but should all as standalone classes. They can create
> {{ExprCodeGenerator}} when they need to generating codes from RexNode, and
> they can also generating codes by themselves. The {{CodeGeneratorContext}}
> can be passed around to collect all reusable statements, and list them in the
> final generated class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
