[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4887#discussion_r148754660
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
    @@ -316,6 +316,13 @@ private void requestSlotFromResourceManager(
     
                pendingRequests.put(allocationID, new 
PendingRequest(allocationID, future, resources));
     
    +           future.whenComplete(
    +                   (value, throwable) -> {
    +                           if (throwable != null && throwable instanceof 
TimeoutException) {
    --- End diff --
    
    I think we should `cancelSlotRequest` for all `Throwables`.


---