[ 
https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237745#comment-16237745
 ] 

ASF GitHub Bot commented on FLINK-7076:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r148807573
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -63,11 +64,14 @@
      * The yarn implementation of the resource manager. Used when the system 
is started
      * via the resource framework YARN.
      */
    -public class YarnResourceManager extends ResourceManager<ResourceID> 
implements AMRMClientAsync.CallbackHandler {
    +public class YarnResourceManager extends ResourceManager<YarnWorkerNode> 
implements AMRMClientAsync.CallbackHandler {
     
        /** The process environment variables. */
        private final Map<String, String> env;
     
    +   /** YARN container map. Package private for unit test purposes. */
    +   final Map<String, YarnWorkerNode> workerNodeMap;
    --- End diff --
    
    Let's make it more visible that this map is a concurrent map by setting the 
type to `CocnurrentHashMap`.


> Implement container release to support dynamic scaling
> ------------------------------------------------------
>
>                 Key: FLINK-7076
>                 URL: https://issues.apache.org/jira/browse/FLINK-7076
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Shuyi Chen
>            Priority: Major
>              Labels: flip-6
>
> In order to support dynamic scaling, the {{YarnResourceManager}} has to be 
> able to dynamically free containers. We have to implement the 
> {{YarnResourceManager#stopWorker}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to