[ 
https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238907#comment-16238907
 ] 

ASF GitHub Bot commented on FLINK-7967:
---------------------------------------

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/4946

    [FLINK-7967] [config] Deprecate Hadoop specific Flink configuration o…

    ## What is the purpose of the change
    
    This PR is mainly for deprecated hadoop specific Flink configuration 
options. We hope people use environment variable HADOOP_CONF_DIR as a 
replacement.
    
    
    ## Brief change log
      - Add a warning message to hadoop configuration in ```flink-conf.yaml``` 
file.
      - Add @Deprecated annotation to ```HDFS_DEFAULT_CONFIG```, 
```HDFS_SITE_CONFIG```, ```PATH_HADOOP_CONFIG```  three fields which in 
```ConfigConstants.java```.
    
    
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-7967

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4946
    
----
commit 51ab28ffc6282a4df7e0b47fad260e00ddc5781e
Author: zhangminglei <[email protected]>
Date:   2017-11-04T10:41:25Z

    [FLINK-7967] [config] Deprecate Hadoop specific Flink configuration options

----


> Deprecate Hadoop specific Flink configuration options
> -----------------------------------------------------
>
>                 Key: FLINK-7967
>                 URL: https://issues.apache.org/jira/browse/FLINK-7967
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Till Rohrmann
>
> I think we should deprecate the hadoop specific configuration options from 
> Flink and encourage people to use instead the environment variable 
> {{HADOOP_CONF_DIR}} to configure the Hadoop configuration directory. This 
> includes:
> {code}
> fs.hdfs.hdfsdefault
> fs.hdfs.hdfssite
> fs.hdfs.hadoopconf
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to