GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/4948

    [FLINK-7979][minor] Use Log.*(Object, Throwable) overload to log exceptions

    ## What is the purpose of the change
    
    When logging an exception, we often convert the exception to string or call 
`.getMessage()`. Instead we can use the log method overloads which take 
`Throwable` as a parameter.
    
    
    ## Brief change log
    
    -  *Remove unnecessary `e.getMessage()`, logging exception use 
LOG.\*(Object, Throwable)*
    
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-7979

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4948
    
----
commit 0aaaca204f7441f3619fd68d7df7aad91e5d5af9
Author: yew1eb <yew...@gmail.com>
Date:   2017-11-04T12:56:35Z

    [FLINK-7979][Minor] Use Log.*(Object, Throwable) overload to log exceptions

----


---

Reply via email to