Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4939#discussion_r149069663
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -981,25 +998,54 @@ public ApplicationReport startAppMaster(
return report;
}
- private static List<String> uploadAndRegisterFiles(
- Collection<File> shipFiles,
+ /**
+ * Uploads and registers a single resource and adds it to
<tt>localResources</tt>.
+ *
+ * @param key
+ * the key to add the resource under
+ * @param fs
+ * the remote file system to upload to
+ * @param appId
+ * application ID
+ * @param localRsrcPath
+ * local path to the file
+ * @param localResources
+ * map of resources
+ *
+ * @return the remote path to the uploaded resource
+ */
+ private static Path setupSingleLocalResource(
+ String key,
FileSystem fs,
- String appId,
- List<Path> remotePaths,
+ ApplicationId appId,
+ Path localRsrcPath,
--- End diff --
Typo `localSrcPath`?
---
