[
https://issues.apache.org/jira/browse/FLINK-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240842#comment-16240842
]
ASF GitHub Bot commented on FLINK-8002:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4962
[FLINK-8002] [table] Fix join window boundary for LESS_THAN and
GREATER_THAN predicates.
## What is the purpose of the change
Fix the computation of join window boundaries for LESS_THAN and
GREATER_THAN predicates if the time attribute of the right input is referenced
on the left side of the predicate.
## Brief change log
- check which input is referenced on which side of the predicate to
determine whether to add or subtract 1 from the boundary.
## Verifying this change
- `JoinTest` was extended to verify the computation of the boundaries.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **n/a**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableJoinBoundaryFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4962.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4962
----
commit e2ca2627c1c3fdcc09bfd20b670d287942185eb0
Author: Fabian Hueske <[email protected]>
Date: 2017-11-06T20:22:35Z
[FLINK-8002] [table] Fix join window boundary for LESS_THAN and
GREATER_THAN predicates.
----
> Incorrect join window boundaries for LESS_THAN and GREATER_THAN predicates
> --------------------------------------------------------------------------
>
> Key: FLINK-8002
> URL: https://issues.apache.org/jira/browse/FLINK-8002
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Critical
> Fix For: 1.4.0
>
>
> The boundaries of LESS_THAN and GREATER_THAN predicates are not correctly
> computed if the time attribute of the right table is referenced on the left
> side of the join predicate.
> Instead of adding (subtracting) 1 millisecond, 1 millisecond is subtracted
> (added).
> Hence, the boundary is off-by-2.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
