GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4981

    7419

    ## What is the purpose of the change
    
    This PR relocates avros jackson dependency in flink-dist.
    
    ## Brief change log
    
    * remove ineffective jackson shading configuration from flink-avro
    * relocate org.codehaus.jackson in flink-dist
      * this way, we keep flink-dist clean, and avro+jackson is still added to 
the fat user-jar
    * add dist shading checks to travis watchdog
    
    ## Verifying this change
    
    I have not tested this yet with an actual job.
    I did check that the relocation is applied and flink-dist is free or 
codehaus.jackson.
    
    Since the relocation is done in flink-dist this change is not covered by 
tests, and could only be covered by an end-to-end test.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (yes)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (on)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7419

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4981.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4981
    
----
commit 2abfda535e97ac100a8aaabd0490a5eee72b2196
Author: zentol <ches...@apache.org>
Date:   2017-11-08T10:58:38Z

    [FLINK-7419][build][avro] Remove ineffective jackson shading

commit 1da869b943b9e2255c68903c1e77c00de9509ab5
Author: zentol <ches...@apache.org>
Date:   2017-11-08T11:04:30Z

    [FLINK-7419][build][avro] Relocate codehaus.jackson in flink-dist

commit 023ec6b8e3daa875e2c29bcd4209f958abbcb202
Author: zentol <ches...@apache.org>
Date:   2017-11-08T11:42:05Z

    [FLINK-7419][travis] Add dist shading check for jackson

----


---

Reply via email to