[
https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243970#comment-16243970
]
ASF GitHub Bot commented on FLINK-8027:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4985
[FLINK-8027] Generalize existing rest handlers to work with an arbitrary
RestfulGateway
## What is the purpose of the change
By letting the existing REST handlers work with an arbitrary RestfulGateway,
they can be used by the Dispatcher as well as the JobMaster, once it
implements
the RestfulGateway.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink generalizedRestHandlers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4985
----
commit 18d8d1af433715a24c2d2e354d8dcf2efb30c49d
Author: Till Rohrmann <[email protected]>
Date: 2017-11-04T13:56:11Z
[FLINK-8000] Sort Rest handler URLS in RestServerEndpoint
Introduce special RestHandlerUrlComparator to sort REST URLs such that
URLs with path parameters are sorted after those without or fewer.
E.g. the following order would be established
/jobs
/jobs/overview
/jobs/:jobid
/jobs/:jobid/config
/:*
commit bdc5d0eaf803475eb9fc550be3ab59cd176c2894
Author: Till Rohrmann <[email protected]>
Date: 2017-11-06T17:48:53Z
[FLINK-8024] Let ClusterOverviewHandler directly extend from
AbstractRestHandler
commit 2ddfa4e57b03fa3e42d60ae8da7b4bbc6b24e777
Author: Till Rohrmann <[email protected]>
Date: 2017-11-06T17:56:01Z
[FLINK-8025] Let DashboardConfigHandler directly extend AbstractRestHandler
commit 03651e6cd66fc173a6758e884e6b9bfdbba3dfcb
Author: Till Rohrmann <[email protected]>
Date: 2017-11-07T09:56:33Z
[FLINK-8026] Let ClusterConfigHandler directly extend AbstractRestHandler
commit 16ec9f41ab26cc8a4f11bbc9ab6c7eb46ad4c8d8
Author: Till Rohrmann <[email protected]>
Date: 2017-11-07T10:04:10Z
[FLINK-8027] Generalize existing rest handlers to work with an arbitrary
RestfulGateway
By letting the existing REST handlers work with an arbitrary RestfulGateway,
they can be used by the Dispatcher as well as the JobMaster, once it
implements
the RestfulGateway.
----
> Generalize existing rest handlers to work with arbitrary RestfulGateway
> -----------------------------------------------------------------------
>
> Key: FLINK-8027
> URL: https://issues.apache.org/jira/browse/FLINK-8027
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to reuse the existing {{AbstractRestHandler}} we should refactor
> them such that they work with arbitrary {{RestfulGateway}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
