Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5011#discussion_r151102649
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/UserDefinedAggFunctions.scala
 ---
    @@ -0,0 +1,107 @@
    +package org.apache.flink.table.utils
    +
    +import org.apache.flink.table.functions.AggregateFunction
    +import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
    +import java.lang.{Integer => JInt}
    +import java.lang.{Float => JFloat}
    +import java.util
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.typeutils.{ObjectArrayTypeInfo, 
TupleTypeInfo}
    +import org.apache.flink.table.api.Types
    +
    +/**
    +  * User-defined aggregation function to compute the TOP 10 most visited 
pages.
    --- End diff --
    
    Adjust the comment:
    ```
    User-defined aggregation function to compute the top 10 Int IDs with the 
highest Float values.
    We use an Array[Tuple2[Int, Float]] as accumulator to store the top 10 
entries.
    ```
    
    Could also be simplified to just store the Float.


---

Reply via email to