[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4544#discussion_r151128673
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
 ---
    @@ -269,6 +272,10 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) 
extends JavaTypeFactoryImp
     
         canonize(newType)
       }
    +
    +  override def getDefaultCharset: Charset = {
    +    Charset.forName(ConversionUtil.NATIVE_UTF16_CHARSET_NAME)
    --- End diff --
    
    Calcite only supports UTF-16, I guess because this is the default of Java 
Strings anyway.


---