[GitHub] flink pull request #5018: [FLINK-7490] [table] Use correct classloader to co...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5018#discussion_r151147760
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
 ---
    @@ -46,7 +46,7 @@ class DataSetAggFunction(
         LOG.debug(s"Compiling AggregateHelper: $genAggregations.name \n\n " +
                     s"Code:\n$genAggregations.code")
         val clazz = compile(
    -      getClass.getClassLoader,
    +      getRuntimeContext.getUserCodeClassLoader,
    --- End diff --
    
    Couldn't we just use `Thread.currentThread().getContextClassLoader` 
everywhere?


---