Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5021#discussion_r151182879
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
 ---
    @@ -133,12 +131,11 @@ private void executeActionAsync(
                        operationFuture.whenCompleteAsync(
                                        (t, throwable) -> {
                                                if (throwable != null) {
    -                                                   if (throwable 
instanceof CancellationException) {
    -                                                           
result.completeExceptionally(throwable);
    -                                                   } else if 
(throwable.getCause() instanceof UnknownKvStateIdException ||
    +                                                   if (
    +                                                                   
throwable.getCause() instanceof UnknownKvStateIdException ||
    --- End diff --
    
    Then, in which cases is an UnknownKvStateIdException thrown? That actually 
sounds more appropriate.


---

Reply via email to