[
https://issues.apache.org/jira/browse/FLINK-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254913#comment-16254913
]
ASF GitHub Bot commented on FLINK-8069:
---------------------------------------
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5016
Hi @fhueske, the PR has been updated. During the refactoring, I got two
questions.
1. Do you think it's still necessary to allow the watermark strategy to be
`null`?
2. Currently, we only provide an `ExistingField` extractor for the rowtime
field. Considering that the `TableSource` may be created from an existing
`DataStream`, I think we should also provide a corresponding extractor, which
automatically reads the timestamp from the `StreamRecord` and set it as a
field. What do you think?
> Support empty watermark strategy for TableSources
> -------------------------------------------------
>
> Key: FLINK-8069
> URL: https://issues.apache.org/jira/browse/FLINK-8069
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> In case the underlying data stream source emits watermarks, it should be
> possible to define an empty watermark strategy for rowtime attributes in the
> {{RowtimeAttributeDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
