[GitHub] flink pull request #5025: [FLINK-8096] [table] Fix time material issue when ...

[xccui]

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5025#discussion_r151604198
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
 ---
    @@ -234,11 +234,12 @@ abstract class StreamTableEnvironment(
                 "UpsertStreamTableSink requires that Table has a full primary 
keys if it is updated.")
             }
             val outputType = sink.getOutputType
    +        val resultType = getResultType(table.getRelNode, optimizedPlan)
    --- End diff --
    
    Shall we consider assembling the `resultType` directly from the `sink` 
parameter?


---