[
https://issues.apache.org/jira/browse/FLINK-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256747#comment-16256747
]
ASF GitHub Bot commented on FLINK-8057:
---------------------------------------
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/5028
[FLINK-8057][FLINK-8059][FLINK-8055][FLINK-8065][FLINK-8062]
This PR simply fixes multiple minor issues, like error messages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink qs-small-stuff
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5028
----
commit ff7e3cf6749a6b6bc898fde871c36661c8629c23
Author: kkloudas <[email protected]>
Date: 2017-11-15T14:32:42Z
[FLINK-8062][QS] Make getKvState() with namespace private.
commit 75c14541fdc52d5446b179e8e660b8a4fd90310c
Author: kkloudas <[email protected]>
Date: 2017-11-15T14:38:36Z
[FLINK-8065][QS] Improve error message when client already shut down.
commit 5e059e968633c4292734ebed209fa1b3c30529a1
Author: kkloudas <[email protected]>
Date: 2017-11-16T16:02:16Z
[FLINK-8055][QS] Deduplicate logging messages about QS start.
commit 2fe078f3927595cbc3c5de6635a710494e0f34b4
Author: kkloudas <[email protected]>
Date: 2017-11-16T16:45:49Z
[FLINK-8059][QS] QS client throws FlinkJobNotFoundException for queries
with unknown jobIds
commit a4d86975967942054d1bd466641e9c835fb014ac
Author: kkloudas <[email protected]>
Date: 2017-11-17T08:26:10Z
[FLINK-8057][QS] Change error message in KvStateRegistry.registerKvState()
----
> KvStateRegistry#registerKvState may randomly fail
> -------------------------------------------------
>
> Key: FLINK-8057
> URL: https://issues.apache.org/jira/browse/FLINK-8057
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Kostas Kloudas
>
> The {{KvStateRegistry#registerKvState}} method is a bit weird. On each call,
> a new KvStateID is generated, and we then check whether a state for this ID
> was already registered. Realistically, this is never the case making the
> check unnecessary, and on the off-chance that it does happen the job will
> fail for no good reason.
> {code}
> KvStateID kvStateId = new KvStateID();
> if (registeredKvStates.putIfAbsent(kvStateId, kvState) == null) {
> KvStateRegistryListener listener = this.listener.get();
> if (listener != null) {
> listener.notifyKvStateRegistered(
> jobId,
> jobVertexId,
> keyGroupRange,
> registrationName,
> kvStateId);
> }
> return kvStateId;
> } else {
> throw new IllegalStateException(kvStateId + " is already registered.");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
