[
https://issues.apache.org/jira/browse/FLINK-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reopened FLINK-8057:
-------------------------------------
{quote}but if it ever fails, then there is something wrong. {quote}
No, it does not mean something is wrong. It means you got a collision on a
randomly generated ID, which albeit unlikely, can just happen.
This should not fail straight away; a simple way to deal with this case it to
just generate another ID. Now if that fails multiple times (the first failure
was already virtually impossible), then you got a failure condition.
> KvStateRegistry#registerKvState may randomly fail
> -------------------------------------------------
>
> Key: FLINK-8057
> URL: https://issues.apache.org/jira/browse/FLINK-8057
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Kostas Kloudas
>
> The {{KvStateRegistry#registerKvState}} method is a bit weird. On each call,
> a new KvStateID is generated, and we then check whether a state for this ID
> was already registered. Realistically, this is never the case making the
> check unnecessary, and on the off-chance that it does happen the job will
> fail for no good reason.
> {code}
> KvStateID kvStateId = new KvStateID();
> if (registeredKvStates.putIfAbsent(kvStateId, kvState) == null) {
> KvStateRegistryListener listener = this.listener.get();
> if (listener != null) {
> listener.notifyKvStateRegistered(
> jobId,
> jobVertexId,
> keyGroupRange,
> registrationName,
> kvStateId);
> }
> return kvStateId;
> } else {
> throw new IllegalStateException(kvStateId + " is already registered.");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
