Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152242064
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -134,9 +138,9 @@ void assignExclusiveSegments(List<MemorySegment>
segments) {
--- End diff --
How about adding (most of) this method's body into the
`AvailableBufferQueue` class, including some more data handling logic? This
way, we can separate the network handling a bit from the buffer logic. (I'll
add comments to some more things to extract below)
Also, you could test the buffer logic alone (inside `AvailableBufferQueue`)
a bit better.
---
