[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261871#comment-16261871
]
ASF GitHub Bot commented on FLINK-7406:
---------------------------------------
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152454790
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -394,7 +419,63 @@ public BufferProvider getBufferProvider() throws
IOException {
return inputGate.getBufferProvider();
}
- public void onBuffer(Buffer buffer, int sequenceNumber) {
+ /**
+ * Requests buffer from input channel directly for receiving network
data.
+ * It should always return an available buffer in credit-based mode
unless
+ * the channel has been released.
+ *
+ * @return The available buffer.
+ */
+ @Nullable
+ public Buffer requestBuffer() {
+ synchronized (bufferQueue) {
+ // Take the floating buffer first if possible.
+ if (bufferQueue.getFloatingBufferSize() > 0) {
+ return bufferQueue.takeFloatingBuffer();
+ } else {
+ return bufferQueue.takeExclusiveBuffer();
+ }
+ }
+ }
+
+ /**
+ * Receives the backlog from the producer's buffer response. If the
number of available
+ * buffers is less than backlog + initialCredit, it will request
floating buffers from the buffer
+ * pool, and then notify unannounced credits to the producer.
+ *
+ * @param backlog The number of unsent buffers in the producer's sub
partition.
+ */
+ void onSenderBacklog(int backlog) throws IOException {
--- End diff --
yes
> Implement Netty receiver incoming pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7406
> URL: https://issues.apache.org/jira/browse/FLINK-7406
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Currently {{PartitionRequestClientHandler}} receives and reads
> {{BufferResponse}} from producer. It will request buffer from {{BufferPool}}
> for holding the message. If not got, the message is staged temporarily and
> {{autoread}} for channel is set false.
> For credit-based mode, {{PartitionRequestClientHandler}} can always get
> buffer from {{RemoteInputChannel}} for reading messages from producer.
> The related works are:
> * Add the backlog of producer in {{BufferResponse}} message structure
> * {{PartitionRequestClientHandler}} requests buffer from
> {{RemoteInputChannel}} directly
> * {{PartitionRequestClientHandler}} updates backlog for
> {{RemoteInputChannel}}, and it may trigger requests of floating buffers from
> {{BufferPool}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
