[
https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263050#comment-16263050
]
ASF GitHub Bot commented on FLINK-7718:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5055
[FLINK-7718] [flip6] Add JobVertexMetricsHandler to DispatcherRestEndpoint
## Brief change log
- *Migrate logic in
`org.apache.flink.runtime.rest.handler.legacy.metrics.JobVertexMetricsHandler`
to new handler and add new handler to DispatcherRestEndpoint.*
- *Add common classes for remaining implementations of
`org.apache.flink.runtime.rest.handler.legacy.metrics.AbstractMetricsHandler`,
which require migration as well*
## Verifying this change
This change added tests and can be verified as follows:
- *Added tests for all new classes and old classes except for
`DispatcherRestEndpoint`*
- *Manually deployed a job locally and verified with `curl` that
JobVertexMetrics can be queried in FLIP-6.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
CC: @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-7718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5055
----
commit b888c876131fa3744baff7393bb75025ccb4b61f
Author: gyao <[email protected]>
Date: 2017-11-22T17:58:03Z
[FLINK-7718] [flip6] Add JobVertexMetricsHandler to DispatcherRestEndpoint
Migrate logic in
org.apache.flink.runtime.rest.handler.legacy.metrics.JobVertexMetricsHandler to
new handler and add new handler to DispatcherRestEndpoint. Add common
classes
for remaining implementations of
org.apache.flink.runtime.rest.handler.legacy.metrics.AbstractMetricsHandler,
which require migration as well.
----
> Port JobVertixMetricsHandler to new REST endpoint
> -------------------------------------------------
>
> Key: FLINK-7718
> URL: https://issues.apache.org/jira/browse/FLINK-7718
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Port {{JobVertexMetricsHandler}} to new REST endpoint.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
