[ 
https://issues.apache.org/jira/browse/FLINK-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264063#comment-16264063
 ] 

ASF GitHub Bot commented on FLINK-8049:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/5057

    [FLINK-8049] [FLINK-8050] REST client/server report netty exceptions on 
shutdown.

    As described in the JIRAs, the rest client/server were swallowing exception 
without any message.
    This PR changes the `shutdown()` methods of the `RestClient` and 
`RestServerEndpoint` to report these exceptions and log them.
    
    R @zentol 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink rest-client-server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5057
    
----
commit b8025c60e9bd184f914ed45c5cb24743d640a25b
Author: kkloudas <kklou...@gmail.com>
Date:   2017-11-22T17:16:04Z

    [FLINK-8050] [rest] REST server reports netty exceptions on shutdown.

commit e8dec1e9964a358d591c9264778e0c630746229e
Author: kkloudas <kklou...@gmail.com>
Date:   2017-11-22T17:25:06Z

    [FLINK-8049] [rest] REST client reports netty exceptions on shutdown.

----


> RestClient#shutdown() ignores exceptions thrown when shutting down netty.
> -------------------------------------------------------------------------
>
>                 Key: FLINK-8049
>                 URL: https://issues.apache.org/jira/browse/FLINK-8049
>             Project: Flink
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>            Priority: Critical
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to