Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5056#discussion_r152762409
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
 ---
    @@ -68,6 +71,12 @@
        /** Descriptor for a rowtime attribute. */
        private List<RowtimeAttributeDescriptor> rowtimeAttributeDescriptors;
     
    +   /** The startup mode for the contained consumer (default is {@link 
StartupMode#GROUP_OFFSETS}). */
    +   protected StartupMode startupMode;
    --- End diff --
    
    should be `private`. We use `protected` setter methods to set optional 
parameters from the builder (see `proctimeAttribute`).


---

Reply via email to